This release contains a critical bug fix which can cause the bot to steal items.



To get this release, head on over to the download page.

 

-----signature-----

Thank you Paraduck, for getting it out so fast! (Thank you also to IB for testing!)

 

-----signature-----

I have discovered another reproducable bug with the bot keeping items:


Upon successful crafting, the person opens the trade window with the bot, but if they push the trade button TWICE FAST (accidentally double clicks the trade button), the item never gets traded and is kept by the bot. We tested this bug after a person had this happen to them (luckily the person said they may have messed up by accidentally clicking the trade button twice), and were able to get it to reproduce.


Sorry for finding bugs, but hopefully it helps others in the long run!


Thanks again Paraduck!

 

-----signature-----

also another bug (posting here as a reminder incase dirk didnt post on the craftbot forums already)


If you check the % on a craft, then clear the window(not closing it) the bot doesn't close the window. If you try another check, the bot will steal the items.


moral of the story, if you wanna clear the window, just close it.

 

-----signature-----

OK, my time is pretty limited for the next couple of days, but I think I see the problem.


IB, I'll send you another PM in a minute. Schugeldson, I'll also send you the version if you want to test it. Unfortunately, I don't have the time to log in and do any sort of thorough test myself.


Changed the following:


- Moved the call to remove the items from the return list to when the trade ends.

- Also added a check here to ensure that the item is not in the inventory before removing. If it is, it won't remove.

- Reset Trade was checking the wrong variable, which in most situations doesn't make a difference. I've corrected this.

 

-----signature-----

Thank you.

 

-----signature-----